Skip to content

Conversation

@begedin
Copy link
Contributor

@begedin begedin commented Jan 2, 2017

What's in this PR?

Adds tos_acceptance parameters to the StripeConnectAccount.create action. Needs a PR on stripity_stripe to get merged first

References

Fixes #602
beam-community/stripity-stripe#178

@begedin
Copy link
Contributor Author

begedin commented Jan 2, 2017

Blocked until we merge beam-community/stripity-stripe#178

@begedin begedin closed this Jan 2, 2017
@begedin begedin reopened this Jan 2, 2017
test "extracts User Agent from the request properly", %{conn: conn} do
assert conn |> put_req_header("user-agent", "Some agent") |> ConnUtils.extract_user_agent == "Some agent"
end
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to ask for these tests, but here they are! ❤️

@begedin
Copy link
Contributor Author

begedin commented Jan 2, 2017

@joshsmith If the stripity_stripe PR is merged before this one, we ought to replace the mix line to target the "2.0" branch again.

@joshsmith joshsmith merged commit d684bc5 into develop Jan 2, 2017
@joshsmith joshsmith deleted the 602-terms-of-use branch January 2, 2017 23:45
@joshsmith joshsmith added this to the Launch Donations milestone Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants